Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused instant return value from CaptureFuture #8758

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Remove unused instant return value from CaptureFuture #8758

merged 1 commit into from
Jul 16, 2024

Conversation

bgw
Copy link
Member

@bgw bgw commented Jul 15, 2024 •
edited
Loading

Description

Appears to be unused.

Testing Instructions

cargo check
cargo check --tests

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 10:06pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 10:06pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 10:06pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2024 10:06pm

@bgw Graphite App
Copy link
Member Author

bgw commented Jul 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bgw and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@bgw bgw marked this pull request as ready for review July 15, 2024 22:51
@bgw bgw requested a review from a team as a code owner July 15, 2024 22:51
@bgw bgw mentioned this pull request Jul 15, 2024
Merged
@bgw bgw requested review from arlyon and wbinnssmith July 15, 2024 23:11
@bgw bgw mentioned this pull request Jul 15, 2024
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Jul 16, 2024 •
edited
Loading

Merge activity

  • Jul 16, 3:06 PM EDT: @bgw started a stack merge that includes this pull request via Graphite.
  • Jul 16, 3:07 PM EDT: @bgw merged this pull request with Graphite.

@bgw bgw merged commit de38c2c into main Jul 16, 2024
55 of 57 checks passed
@bgw bgw deleted the bgw/rm-unused-instant branch July 16, 2024 19:07
@kdy1 kdy1 mentioned this pull request Jul 17, 2024
Merged
@sokra sokra mentioned this pull request Jul 18, 2024
Merged
bgw pushed a commit to vercel/next.js that referenced this pull request Jul 18, 2024
@sokra
update turbopack (#67874)
b3a994d 
* vercel/turborepo#8767 <!-- Niklas Mischkulnig -
Update Turbopack members in labeler -->
* vercel/turborepo#8722 <!-- Niklas Mischkulnig -
Use fs and vm for async chunk loading in Node -->
* vercel/turborepo#8758 <!-- Benjamin Woodruff -
Remove unused instant return value from `CaptureFuture` -->
* vercel/turborepo#8760 <!-- Benjamin Woodruff -
Delete dead raw_vc_set module -->
* vercel/turborepo#8761 <!-- Benjamin Woodruff -
Delete dead keyed_cell module -->
* vercel/turborepo#8755 <!-- Donny/강동윤 - feat:
Enable tree shaking in next.js -->
* vercel/turborepo#8769 <!-- Benjamin Woodruff -
Rewrite IdFactory and IdFactoryWithReuse -->
* vercel/turborepo#8771 <!-- Benjamin Woodruff - Add
u64 ExecutionId type -->
* vercel/turborepo#8735 <!-- Tobias Koppers -
turbo-tasks this calls -->
* vercel/turborepo#8775 <!-- Tobias Koppers -
improve failsafe_analyse -->
* vercel/turborepo#8776 <!-- Tobias Koppers - notify
tasks when collectibles change -->
* vercel/turborepo#8778 <!-- Tobias Koppers - fix
collectibles counting -->
* vercel/turborepo#8736 <!-- Tobias Koppers -
Refactor task arguments to be a single one -->
* vercel/turborepo#8737 <!-- Tobias Koppers - remove
ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@bgw
Remove unused instant return value from CaptureFuture (vercel/turbo…
bfb2ec9 
…repo#8758)

### Description

Appears to be unused.

### Testing Instructions

```
cargo check
cargo check --tests
```
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@bgw
Remove unused instant return value from CaptureFuture (vercel/turbo…
7555e14 
…repo#8758)

### Description

Appears to be unused.

### Testing Instructions

```
cargo check
cargo check --tests
```
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@bgw
Remove unused instant return value from CaptureFuture (vercel/turbo…
4361d0b 
…repo#8758)

### Description

Appears to be unused.

### Testing Instructions

```
cargo check
cargo check --tests
```
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@bgw
Remove unused instant return value from CaptureFuture (vercel/turbo…
968009f 
…repo#8758)

### Description

Appears to be unused.

### Testing Instructions

```
cargo check
cargo check --tests
```
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
@sokra @ForsakenHarmony
update turbopack (#67874)
db6b05a 
* vercel/turborepo#8767 <!-- Niklas Mischkulnig -
Update Turbopack members in labeler -->
* vercel/turborepo#8722 <!-- Niklas Mischkulnig -
Use fs and vm for async chunk loading in Node -->
* vercel/turborepo#8758 <!-- Benjamin Woodruff -
Remove unused instant return value from `CaptureFuture` -->
* vercel/turborepo#8760 <!-- Benjamin Woodruff -
Delete dead raw_vc_set module -->
* vercel/turborepo#8761 <!-- Benjamin Woodruff -
Delete dead keyed_cell module -->
* vercel/turborepo#8755 <!-- Donny/강동윤 - feat:
Enable tree shaking in next.js -->
* vercel/turborepo#8769 <!-- Benjamin Woodruff -
Rewrite IdFactory and IdFactoryWithReuse -->
* vercel/turborepo#8771 <!-- Benjamin Woodruff - Add
u64 ExecutionId type -->
* vercel/turborepo#8735 <!-- Tobias Koppers -
turbo-tasks this calls -->
* vercel/turborepo#8775 <!-- Tobias Koppers -
improve failsafe_analyse -->
* vercel/turborepo#8776 <!-- Tobias Koppers - notify
tasks when collectibles change -->
* vercel/turborepo#8778 <!-- Tobias Koppers - fix
collectibles counting -->
* vercel/turborepo#8736 <!-- Tobias Koppers -
Refactor task arguments to be a single one -->
* vercel/turborepo#8737 <!-- Tobias Koppers - remove
ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
@sokra @ForsakenHarmony
update turbopack (#67874)
a85284d 
* vercel/turborepo#8767 <!-- Niklas Mischkulnig -
Update Turbopack members in labeler -->
* vercel/turborepo#8722 <!-- Niklas Mischkulnig -
Use fs and vm for async chunk loading in Node -->
* vercel/turborepo#8758 <!-- Benjamin Woodruff -
Remove unused instant return value from `CaptureFuture` -->
* vercel/turborepo#8760 <!-- Benjamin Woodruff -
Delete dead raw_vc_set module -->
* vercel/turborepo#8761 <!-- Benjamin Woodruff -
Delete dead keyed_cell module -->
* vercel/turborepo#8755 <!-- Donny/강동윤 - feat:
Enable tree shaking in next.js -->
* vercel/turborepo#8769 <!-- Benjamin Woodruff -
Rewrite IdFactory and IdFactoryWithReuse -->
* vercel/turborepo#8771 <!-- Benjamin Woodruff - Add
u64 ExecutionId type -->
* vercel/turborepo#8735 <!-- Tobias Koppers -
turbo-tasks this calls -->
* vercel/turborepo#8775 <!-- Tobias Koppers -
improve failsafe_analyse -->
* vercel/turborepo#8776 <!-- Tobias Koppers - notify
tasks when collectibles change -->
* vercel/turborepo#8778 <!-- Tobias Koppers - fix
collectibles counting -->
* vercel/turborepo#8736 <!-- Tobias Koppers -
Refactor task arguments to be a single one -->
* vercel/turborepo#8737 <!-- Tobias Koppers - remove
ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
@sokra @ForsakenHarmony
update turbopack (#67874)
3d71658 
* vercel/turborepo#8767 <!-- Niklas Mischkulnig -
Update Turbopack members in labeler -->
* vercel/turborepo#8722 <!-- Niklas Mischkulnig -
Use fs and vm for async chunk loading in Node -->
* vercel/turborepo#8758 <!-- Benjamin Woodruff -
Remove unused instant return value from `CaptureFuture` -->
* vercel/turborepo#8760 <!-- Benjamin Woodruff -
Delete dead raw_vc_set module -->
* vercel/turborepo#8761 <!-- Benjamin Woodruff -
Delete dead keyed_cell module -->
* vercel/turborepo#8755 <!-- Donny/강동윤 - feat:
Enable tree shaking in next.js -->
* vercel/turborepo#8769 <!-- Benjamin Woodruff -
Rewrite IdFactory and IdFactoryWithReuse -->
* vercel/turborepo#8771 <!-- Benjamin Woodruff - Add
u64 ExecutionId type -->
* vercel/turborepo#8735 <!-- Tobias Koppers -
turbo-tasks this calls -->
* vercel/turborepo#8775 <!-- Tobias Koppers -
improve failsafe_analyse -->
* vercel/turborepo#8776 <!-- Tobias Koppers - notify
tasks when collectibles change -->
* vercel/turborepo#8778 <!-- Tobias Koppers - fix
collectibles counting -->
* vercel/turborepo#8736 <!-- Tobias Koppers -
Refactor task arguments to be a single one -->
* vercel/turborepo#8737 <!-- Tobias Koppers - remove
ConcreteTaskInput in favor of the original rust datatypes -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@arlyon arlyon Awaiting requested review from arlyon

@wbinnssmith wbinnssmith Awaiting requested review from wbinnssmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgw @sokra